feat(test): add flashing timer style (@gianpena) #7139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeytypegeorge
added
frontend
Contributor
|
This is beautiful Gian. |
Contributor
Author
|
Contributor
He's phocking gorgeous |
gianpena
force-pushed
the
flashing-timer
branch
from
1574d3b to
b9ec572
Compare
Miodec
added
the
waiting for update
gianpena
force-pushed
the
flashing-timer
branch
from
b9ec572 to
0983b7a
Compare
github-actions
bot
removed
the
waiting for update
github-actions
bot
added
waiting for update
gianpena
force-pushed
the
flashing-timer
branch
from
1e68c02 to
b40a195
Compare
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
as opposed to displayTime which could be in m:ss format and therefore will not play nicely with parseInt
gianpena
force-pushed
the
flashing-timer
branch
from
b40a195 to
0c700b9
Compare
github-actions
bot
removed
the
waiting for update
Miodec
added a commit
that referenced
this pull request
Nov 28, 2025
### Description This copies the existing `text` timerstyle except on timed modes, where it will only show the remaining progress (seconds) on every 15th second (shows on 1:00, 45, 30, 15 and 0). The motivation for this addition was that I wanted a middle ground between the `text` timerstyle (in my opinion just a _little_ too distracting) and no live progress indicator at all (I lose track of how much time remains in the test), and I believe this achieves that middle ground. --------- Co-authored-by: Miodec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This copies the existing
texttimerstyle except on timed modes, where it will only show the remaining progress (seconds) on every 15th second (shows on 1:00, 45, 30, 15 and 0).The motivation for this addition was that I wanted a middle ground between the
texttimerstyle (in my opinion just a little too distracting) and no live progress indicator at all (I lose track of how much time remains in the test), and I believe this achieves that middle ground.